search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Add motivation and rudimentary running instructions to README.md #34

Closed cgrushko closed 6 years ago

cgrushko commented 6 years ago

Based on @petroseskinder 's https://github.com/bazelbuild/BUILD_file_generator/pull/24.

cgrushko commented 6 years ago

@spomorski I can't add you to the list of reviewers for some reason. Let me know if that's no what you had in mind and I should add more.

tualeron commented 6 years ago

I think you or someone with permissions has to give me write access to that repository.

On Dec 18, 2017 23:31, "Carmi Grushko" notifications@github.com wrote:

@spomorski https://github.com/spomorski I can't add you to the list of reviewers for some reason.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/34#issuecomment-352636993, or mute the thread https://github.com/notifications/unsubscribe-auth/AbdI8ssKw-pdkYnR4VThkrQg_kEZ0hF2ks5tBzwRgaJpZM4RGbZ9 .

tualeron commented 6 years ago

Disregard my last comment, I misread the commit. :)

On Thu, Jan 18, 2018 at 1:07 PM, Serge notifications@github.com wrote:

@spomorski commented on this pull request.

Can we also add the usage instructions? We need this to update the Maven migration guide.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/34#pullrequestreview-89879144, or mute the thread https://github.com/notifications/unsubscribe-auth/AbdI8pPhLUq9SUjeAG6IBKZtPdzoJ-Xxks5tL4hggaJpZM4RGbZ9 .

cgrushko commented 6 years ago

@spomorski we recently discovered that there's some bug in BFG which makes it not work, so even with instructions it might not be good enough yet.

tualeron commented 6 years ago

Thanks for the info, any ETA on the fix?

On Thu, Jan 18, 2018 at 1:44 PM, Carmi Grushko notifications@github.com wrote:

@spomorski https://github.com/spomorski we recently discovered that there's some bug in BFG which makes it not work, so even with instructions it might not be good enough yet.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bazelbuild/BUILD_file_generator/pull/34#issuecomment-358742674, or mute the thread https://github.com/notifications/unsubscribe-auth/AbdI8oIPFT40Ik1TDGyYzsQbIP6IRBH5ks5tL5EPgaJpZM4RGbZ9 .

cgrushko commented 6 years ago

Er... not yet :)