search

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Update rules_scala #37

Closed cushon closed 6 years ago

cushon commented 6 years ago

bazelbuild/bazel#5483

lfpino commented 6 years ago

Seems like @laszlocsomor can't approve either. @dslomov do you have any idea who can approve this?

dslomov commented 6 years ago

Just did (using my bazelbuild organization superpowers)

lfpino commented 6 years ago

I'm somewhat sad I don't have those superpowers :(

dslomov commented 6 years ago

Superpowers are dangerous (you can accidentally do a destructive push) so we are are not giving them out much (I got those just a week ago out of necessity). The list of folks with write access to this repo is here: https://github.com/bazelbuild/BUILD_file_generator/settings/collaboration, so for larger changes they should be pinged to do the reviews.

dslomov commented 6 years ago

(and there is no way to give "approve but not write" permissions for the repo)

petroseskinder commented 6 years ago

I used to be able to approve... do i still have these permissions?

lfpino commented 6 years ago

I can't access https://github.com/bazelbuild/BUILD_file_generator/settings/collaboration, I'm actually not even getting emails from this thread.

cushon commented 6 years ago

@dslomov thanks for approving, can you also merge the PR? I'm not sure anyone else on the review has the necessary permissions.

dslomov commented 6 years ago

@petroseskinder yes you are listed as collaborator with write access to this repo

dslomov commented 6 years ago

I can't access https://github.com/bazelbuild/BUILD_file_generator/settings/collaboration, I see, github ACL management is not awesome.

I'm actually not even getting emails from this thread. That is weird - I think you can probably set that up in GutHub settings