bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files
Apache License 2.0
39 stars 19 forks source link

Please move from native to Starlark rules for external git/http repositories #39

Closed aehlig closed 5 years ago

aehlig commented 5 years ago

From version 0.20 onwards, bazel by default will no longer support the native http and git repositories. Please switch to the Starlark versions of those rules.

For more background, see

Once migrated, please also file an issue against http://github.com/bazelbuild/continuous-integration to reenable testing of your project as a bazel downstream project.

hlopko commented 5 years ago

Hi all, this flag is flipped now at bazel@HEAD and will be the default behavior of Bazel 0.20. I'll disable this project on our downstream pipeline (https://buildkite.com/bazel/bazel-with-downstream-projects-bazel/builds/537#acf06c47-10e5-4fb3-8610-bf0cea34a398). Please fix quickly and create an issue at bazelbuild/continuous-integration to reenable. Keep in mind that we are now not catching unintentional breakages of this project in bazel@HEAD.

meteorcloudy commented 5 years ago

@greggdonovan @cgrushko Can you help fixing this?

greggdonovan commented 5 years ago

@meteorcloudy Sure, I'll grab this today.

greggdonovan commented 5 years ago

Sorry for the delay. I just posted a PR that removes the native http_archive usage and adds some other incompatibility changes and updates.

meteorcloudy commented 5 years ago

@greggdonovan Please ping me again when it's merged, I'll re-enable build file generator on Bazel CI job for downstream projects.

hlopko commented 5 years ago

Thanks Greg, let me close this issue now!

hlopko commented 5 years ago

Hups, I'm afraid you'll have to close it :)