Tests are failing with JDK 11

bazelbuild / BUILD_file_generator

Generate BUILD files for your Java files

Apache License 2.0

39 stars 19 forks source link

Tests are failing with JDK 11 #53

Open meteorcloudy opened 5 years ago

meteorcloudy commented 5 years ago

https://buildkite.com/bazel/build-file-generator/builds/93

There was 1 failure:
1) ruleKindDetection(com.google.devtools.build.bfg.JavaSourceFileParserTest)
java.lang.AssertionError: Not true that <[/src/x/Binary.java=java_library, /src/x/SomeTest.java=java_test, /src/x/AbstractTest.java=java_library]> contains exactly <[/src/x/Binary.java=java_binary, /src/x/SomeTest.java=java_test, /src/x/AbstractTest.java=java_library]>. It is missing <[/src/x/Binary.java=java_binary]> and has unexpected items <[/src/x/Binary.java=java_library]>

/cc @philwo @greggdonovan

meteorcloudy commented 5 years ago

The project is disabled in Bazel's downstream test due to this issue, please help fixing.

meteorcloudy commented 5 years ago

@cgrushko @petroseskinder

dslomov commented 5 years ago

@greggdonovan @petroseskinder ptal as you are listed as CODEOWNERS.

If the project is unmaintained, I would rather mark it as such and archive the GitHub repo.

greggdonovan commented 5 years ago

@dslomov I don't think either @petroseskinder or I are actively working on the project. I'm fine with archiving the project.

philwo commented 5 years ago

Thanks for the update!

If I don't hear back from @petroseskinder until Monday, I'll archive this project then and will remove it from CI. We can always unarchive it again, in case someone wants to take up the work on this in the future.

philwo commented 5 years ago

I'm archiving this now.