bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.
https://registry.bazel.build
Apache License 2.0
244 stars 286 forks source link

Upstream Bzlmod changes to original repositories #124

Closed meteorcloudy closed 1 month ago

meteorcloudy commented 2 years ago

As part of https://github.com/bazelbuild/bazel-central-registry/issues/7, there were many Bazel modules checked in the BCR with custom MODULE.bazel files and patches while the original project doesn't natively support Bzlmod. To drive the Bzlmod migration in the community, we need help to upstream the MODULE.bazel files and patches back to the original repositories.

The list of modules in the BCR that already natively supports Bazel but not yet migrated to Bzlmod are:

Note that the MODULE.bazel files and patches in the BCR for them only ensure the minimal use case can work, to fully migrate those projects to Bzlmod probably requires extra work.

alexeagle commented 2 years ago

For anyone who'd be motivated by a payout for helping here, there's money in the https://opencollective.com/bazel-rules-authors-sig which we can turn into a bug bounty here.

alexeagle commented 2 years ago

Here's a start for rules_python https://github.com/bazelbuild/rules_python/pull/744

alexeagle commented 2 years ago

FYI I checked off rules_nodejs - I don't think it belonged on that list though, since no file for it was ever committed as part of #7. (same for rules_sass - I assume those are only needed for building some documentation site and not for the bazel binary, so they were omitted from #7 as not strictly needed for building Bazel)

meteorcloudy commented 2 years ago

@alexeagle Regardless of #7, rules_nodejs still fits the definition of "The list of modules in the BCR that already natively supports Bazel but not yet migrated to Bzlmod", right? Don't you think rules_nodejs should also support Bzlmod natively giving "aspect_rules_js" still depends on it?

alexeagle commented 2 years ago

Sure, I was a bit too pedantic there - rules_nodejs is migrated to bzlmod already.

Vertexwahn commented 6 months ago

FYI: Abseil and Google Test have now a MODULE.bazel file.

PR for gflags is open since Sep 16, 2023: https://github.com/gflags/gflags/pull/353

mering commented 6 months ago

Should we link upstream tracking issues and PRs here as well?

protobuf: protocolbuffers/protobuf#13618 grpc: grpc/grpc#35271

mering commented 6 months ago

Furthermore, upb is deprecated: https://github.com/protocolbuffers/upb#readme

Wyverald commented 1 month ago

This issue is largely outdated -- most (if not all) of the mentioned repos now have first-class Bzlmod support. (Except c-ares, which doesn't have any Bazel files at all.)