bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.
https://registry.bazel.build
Apache License 2.0
245 stars 305 forks source link

Update bcr_validation.py to handle overlay files #2249

Closed lalten closed 3 months ago

lalten commented 3 months ago

Allow using the new overlay format (https://github.com/bazelbuild/bazel-central-registry/issues/1566)

Tested with https://github.com/bazelbuild/bazel-central-registry/pull/2240

This is an alternative to https://github.com/bazelbuild/bazel-central-registry/pull/2046 (which I hadn't seen previously :see_no_evil: )

fzakaria commented 2 months ago

how do you handle having a module then be backwards comptable for non-overlay Bazel versions?

I thought about maybe turning the overlay's via the NGINX server as a PATCH file live?

The MODULE.bazel also doesn't have a bazel version compatability. It should be > 7.X right?

lalten commented 2 months ago

The MODULE.bazel also doesn't have a bazel version compatability. It should be > 7.X right?

Needs to be >= 7.2.1 due to https://github.com/bazelbuild/bazel/pull/22811