search

bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.
https://registry.bazel.build
Apache License 2.0
233 stars 261 forks source link

Restore minimal Python support in Protobuf v25+ #2254

Closed mering closed 3 weeks ago

mering commented 4 weeks ago

In Protobuf v25 Python support with Bzlmod broke with the introduction of system_python. This is a regression compared to previous versions.

This re-adds minimal Python support and adds a target to the presubmit check in order to avoid backsliding in the future.

This backports the following patches:

  1. https://github.com/protocolbuffers/protobuf/commit/e1bf1f048e783578bcbdaa4572ce3c93908b6494
  2. https://github.com/protocolbuffers/protobuf/commit/2eb4d69ed51c475a77ecd62742ef5064557b531f
bazel-io commented 4 weeks ago

Hello @zhangskz, @mkruskal-google, @googleberg, modules you maintain (protobuf) have been updated in this PR. Please review the changes.

mering commented 4 weeks ago

@zhangskz This is backporting the patches you reviewed.

mering commented 4 weeks ago

@fmeum could you please trigger the tests?

fmeum commented 4 weeks ago

Could you use this link for the archive instead: https://github.com/protocolbuffers/protobuf/releases/download/v26.0/protobuf-26.0.tar.gz That should avoid the failure.