[Bug]: dismiss_approvals workflow dismisses approvals that occur after any changes that would dismiss the approval

bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.

https://registry.bazel.build

Apache License 2.0

245 stars 305 forks source link

[Bug]: dismiss_approvals workflow dismisses approvals that occur after any changes that would dismiss the approval #2363

Open jsharpe opened 3 months ago

jsharpe commented 3 months ago

What happened?

Made a change to a PR that would require re-approval by module owner. Re-approved the PR before the github action to dimiss_approvals completed. Approval got dismissed

Version

N/A - bug in github workflow

How to reproduce

No response

Any other information?

Can be seen in PR https://github.com/bazelbuild/bazel-central-registry/pull/2359

jsharpe commented 3 months ago

Also, its kind of annoying that it also dimisses changes by myself when I am the maintainer of the module. Maybe it should also check if the changes have been made by the maintainer not to dismiss any approvals?