search

bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.
https://registry.bazel.build
Apache License 2.0
244 stars 303 forks source link

Add gonzojive_protobuf_javascript module. #2853

Closed gonzojive closed 3 days ago

gonzojive commented 6 days ago

Checked with python3 tools/bcr_validation.py --check=protobuf_javascript_esm.

The module in question is my fork of the protobuf-javascript repo. The changes in the fork are unlikely to be accepted upstream (see https://github.com/protocolbuffers/protobuf-javascript/pull/156).

bazel-io commented 6 days ago

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protobuf_javascript_esm) have been updated in this PR. Please review the changes.

meteorcloudy commented 6 days ago

Maybe protobuf_javascript_gonzojive is a better name to indicate this is a fork?

fmeum commented 6 days ago

Following other examples in the registry, <org>_protobuf_javascript would fit well.

bazel-io commented 5 days ago

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (gonzojive_protobuf_javascript) have been updated in this PR. Please review the changes.

gonzojive commented 5 days ago

Done.

Wyverald commented 5 days ago

please fix check failures.

gonzojive commented 5 days ago

I suspect it will work now. I removed debian10 due to a C++ error in protobuf that I'm not sure how to resolve.