search

bazelbuild / bazel-central-registry

The central registry of Bazel modules for the Bzlmod external dependency system.
https://registry.bazel.build
Apache License 2.0
261 stars 340 forks source link

rules_* modules broken with Bazel 8.0.0rc4 #3260

Open meteorcloudy opened 3 days ago

meteorcloudy commented 3 days ago

The following modules are broken with Bazel@8.0.0rc4:

BCR Bazel Compatibility Test: https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/72

This may have some overlap with https://github.com/bazelbuild/bazel-central-registry/issues/3056

rules_android@0.5.1

Maintainers: @ted-xie, @ahumesky

nya3jp commented 3 days ago

FYI: rules_contest has been fixed - the failure was due to the flag flip of --incompatible_disallow_empty_glob.

p0deje commented 3 days ago

rules_ruby are fixed in 0.14.1, the issue was usage of --incompatible_remote_results_ignore_disk in tests.

ouillie commented 3 days ago

rules_wasm fixed: https://github.com/bazelbuild/bazel-central-registry/pull/3268.

Filed https://github.com/bazelbuild/bazel/issues/24499 to discuss a better solution, but was able to just duplicate some data as a workaround. The breaking change stems from https://github.com/bazelbuild/bazel/commit/27487cf11f61eb23108f8df129dc1a00ee1a4370 which causes the patch tool for http_archive to always receive a -p option, even when patch_args is empty. Is that an issue for anybody else? Or was that just because of my abuse of patch_tool.

fmeum commented 2 days ago

rules_jni@0.10.3 contains a fix.

@ouillie Can you use patch_cmds instead? That's the recommended way to run arbitrary commands.

EdSchouten commented 1 day ago

rules_jsonnet@0.6.0

Maintainers: @EdSchouten

It looks like all of these breakages are caused by jsonnet, not rules_jsonnet. Unfortunately, I am not able to make able to make contributions to that repository directly. Sorry!

Once these build failures are addressed on the jsonnet side, I'd be more than happy to cut a new release of rules_jsonnet that depends on it.

meteorcloudy commented 1 day ago

@EdSchouten Yes, jsonnet is also identified in https://github.com/bazelbuild/bazel-central-registry/issues/3056 @mortenmj Can you help fixing this since you contributed the initial BCR module.

avdv commented 1 day ago

rules_sh, rules_nixpkgs and rules_haskell all fail with the same error:

    File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/2bbac50a5364a2d14c5e3065383ed7e2/external/rules_sh+/sh/posix.bzl", line 11, column 55, in <toplevel>
        load("@bazel_tools//tools/cpp:lib_cc_configure.bzl", "get_cpu_value")
Error: file '@bazel_tools//tools/cpp:lib_cc_configure.bzl' does not contain symbol 'get_cpu_value'

We were relying on this macro, but apparently it has been removed and the one in rules_cc is private. We are going to vendor a copy of this macro into our rules to solve this, but maybe others are also having this issue and copying this code around seems not very maintainable. WDYT?

meteorcloudy commented 1 day ago

@avdv I think we could expose this in https://github.com/bazelbuild/rules_cc/blob/8395ec0172270f3bf92cd7b06c9b5b3f1f679e88/cc/toolchains/toolchain_config_utils.bzl#L22

Sent https://github.com/bazelbuild/rules_cc/pull/283

jmillikin commented 1 day ago

rules_flex fix: https://github.com/bazelbuild/bazel-central-registry/pull/3285

chickenandpork commented 1 day ago

rules_Synology will take a few days to fix: I butchered the bcr template and I’m afk 3 days. I can’t reproduce the failure but have a fix for a guess of the cause into v0.0.3