bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
387 stars 178 forks source link

Add gazelle plugin to CI and distribution mechanism #424

Closed tetromino closed 1 year ago

tetromino commented 1 year ago

After #400, the gazelle plugin has been cleanly separated out into its own bazel workspace, which will soon finally allow us to mark it stable. But this means:

tetromino commented 1 year ago

Note: as a followup, I will try to see if we can clean up distro BUILD files to not include distro-only targets. I think this is feasible by updating to a newer version of rules_pkg, but the change is big enough that it would be best done as a separate followup PR.

achew22 commented 1 year ago

This LGTM. Obviously gotta fixup CI but conceptually this seems like the right direction. Thanks @tetromino!

alexeagle commented 1 year ago

This module also needs to be added to the Bazel Central Registry in order to use it - @tetromino is that on your list? Want a PR for it?

tetromino commented 1 year ago

@alexeagle - yes, it's my next todo; I just need to generate the tarball

alexeagle commented 1 year ago

I guess it's a wider discussion, but I think we could chat about distribution of the entire repo instead, it's tremendously simpler.