search

bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
387 stars 180 forks source link

Modify actions in order not to need `toolchain` param #455

Closed kotlaja closed 1 year ago

kotlaja commented 1 year ago

All actions which use tool or executable for which is not clear if it comes from a toolchain, must set a toolchain parameter ( migration of Automatic Exec Groups).

As we discussed internally, I've modified actions so that it's recognised that tools are not from the toolchain. Hence, there will not be an error which states Couldn't identify if tools are from implicit dependencies or a toolchain. Please set the toolchain parameter. If you're not using a toolchain, set it to 'None'.. Hence, no need for the toolchain parameter.

comius commented 1 year ago

Question: does this break compatibility with older Bazel releases (before 6.3.2)?

If it does, that is not necessarily a blocker, but it is something that we must note in changelog and release notes, and it would affect what version number the next release should have.

Knowing Bazel implementation I think this should work down to at least 4.0.0. We probably should have CI tests for this, so that we don’t need to confirm each PR manually.