search

bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
387 stars 180 forks source link

analysis_test_e2e_test is failing with Bazel@HEAD #458

Closed sgowroji closed 11 months ago

sgowroji commented 1 year ago

https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3293#018a728b-ccef-4f35-a36a-43b6b74145a0

Platform : Ubuntu, MacOS, Windows

Logs:

//tests:analysis_test_e2e_test                                           FAILED in 3 out of 3 in 17.6s

Steps:

git clone https://github.com/bazelbuild/bazel-skylib.git  && cd bazel-skylib
git reset 0171c69e5cc691e2d0cd9f3f3e4c3bf112370ca2 --hard
export USE_BAZEL_VERSION=c08cc85b1e2a52ae8e5c0fd998a2067916ec7448
 bazel test -- //... @bazel_skylib_gazelle_plugin//...

CC Greenteam @fweikert

comius commented 12 months ago

The first breakage happened from Wednesday to Thursday 7th Sep 2023: https://buildkite.com/bazel/bazel-skylib/builds?branch=main

It looks it was caused by a change in Bazel. Autosheriff didn't bisect the problem (possibly because skylib includes Bazel@HEAD test). cc @meteorcloudy

The problem looks related to Python rules (or java rules). Do you know of any relevant changes? cc @rickeylev @hvadehra

meteorcloudy commented 12 months ago

We can use https://github.com/bazelbuild/bazelisk#--bisect to debug this.

sgowroji commented 12 months ago

Bisect Results: https://github.com/bazelbuild/bazel/commit/b27ca73617c5319d4b15a9e5ba499cf476679a95

 bazelisk --bisect=e8f5082a266ad71693aa436ef56280e6c457353b..HEAD test -- //... @bazel_skylib_gazelle_plugin//...
meteorcloudy commented 12 months ago

Interesting, looks like it's my fault, I'll take a look soon!

meteorcloudy commented 12 months ago

In https://github.com/bazelbuild/bazel/commit/b27ca73617c5319d4b15a9e5ba499cf476679a95, I did update the rules_python version introduced by the WORKSPACE suffix.

meteorcloudy commented 12 months ago

Maybe we need to fix the test setup here: https://github.com/bazelbuild/bazel-skylib/blob/main/tests/analysis_test_test.sh#L82

meteorcloudy commented 12 months ago

Can anyone review https://github.com/bazelbuild/bazel-skylib/pull/462?