search

bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
387 stars 180 forks source link

versions: Don't fail on Bazel dev builds #463

Closed fmeum closed 11 months ago

fmeum commented 11 months ago

Dev builds of Bazel are assumed to be more recent than any released version.

fmeum commented 11 months ago

@Wyverald Could you review? It's almost identical to https://github.com/bazel-contrib/bazel_features/blob/541c6ac87a93c95df76388a6f1d0b3f65d02fbac/private/parse.bzl#L19C1-L20C1.

fmeum commented 11 months ago

It would be great if we could have a new Skylib release for https://github.com/bazelbuild/bazel-skylib/commit/8386b9d32bf69dd2d2f92d9ca39582cf6dabeb37 and https://github.com/bazelbuild/bazel-skylib/commit/0171c69e5cc691e2d0cd9f3f3e4c3bf112370ca2 (and the current PR) before BazelCon.

fmeum commented 10 months ago

@brandjon Would it be possible to release a new version of Skylib with these fixes?