search

bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
387 stars 180 forks source link

Brings in very old version of rules_cc: Eliminate or update? #475

Closed cpsauer closed 4 months ago

cpsauer commented 10 months ago

Hi wonderful Bazelers,

I was debugging something else and noticed that skylib brings in a very old version of rules_cc, breaking some things.

My understanding is that the dependency could probably be eliminated, since the cc rules used are built-in anyway--but failing that perhaps it would be worth an update?

Lmk what you think. Happy to help (though it might just be fastest to make the change, once you decide which makes more sense).

Thanks so much for all you do! Chris (ex-Googler)

keith commented 10 months ago

looks to me like it's only used for the imports, which is still not required. If it were me I would break that connection until it's required. Updating also seems harmless though

cpsauer commented 9 months ago

Sounds like we're on the same page. Thanks, as always, for being great Keith. Posted #476 doing just that, if you can merge.