bazelbuild / bazel-skylib

Common useful functions and rules for Bazel
https://bazel.build/
Apache License 2.0
376 stars 179 forks source link

tests fail on windows after git clone with autocrlf=true #526

Open peakschris opened 1 month ago

peakschris commented 1 month ago

After git clone of this repo with autocrlf=true on windows, 31 tests fail. These are diff tests that are comparing files output by tooling that always generates LF, with repo files that are sometimes CRLF and sometimes LF.

I believe the solution is for all windows users to clone with autocrlf=input, or to check in a .gitattributes file so everyone gets LF files:

.gitattributes:

# The behavior of core.autocrlf=input is to force conversion to LF on addition
# into the repository and not to perform any conversion on checkout; that is,
# to always use LF endings regardless of the user's settings. This is set in 
# .gitattributes as '* eol=lf'
* eol=lf