search

bazelbuild / bazel-toolchains

Repository that hosts Bazel toolchain configs for remote execution and related support tools.
Apache License 2.0
186 stars 96 forks source link

Toolchain configs for marketplace.gcr.io/google/rbe-ubuntu16-04, Bazel 3.7.0 (2020/10/21) #918

Closed rbe-toolchains-robot closed 4 years ago

rbe-toolchains-robot commented 4 years ago

Container Digest: f6568d8168b14aafd1b707019927a63c2d37113a03bcee188218f99bd0327ea1

rbe-toolchains-pr-bot commented 4 years ago

/gcbrun

or-shachar commented 4 years ago

Hey - any reason this doesn't get merged and released? I can't follow the GCB link.

smukherj1 commented 4 years ago

Looks like absl compilation is failing with:

ERROR: /workspace/external-src/absl/strings/BUILD.bazel:608:1: Couldn't build file absl/strings/charconv_benchmark: Linking of rule '//absl/strings:charconv_benchmark' failed (Exit 1)
bazel-out/k8-fastbuild/bin/_solib_k8/libabsl_Sstrings_Slibstrings.so: error: undefined reference to '__muloti4'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
ERROR: /workspace/external-src/absl/flags/BUILD.bazel:427:1: Couldn't build file absl/flags/path_util_test: Linking of rule '//absl/flags:path_util_test' failed (Exit 1)
bazel-out/k8-fastbuild/bin/_solib_k8/libabsl_Sstrings_Slibstrings.so: error: undefined reference to '__muloti4'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
ERROR: /workspace/external-src/absl/strings/BUILD.bazel:195:1: Couldn't build file absl/strings/memutil_test: Linking of rule '//absl/strings:memutil_test' failed (Exit 1)
bazel-out/k8-fastbuild/bin/_solib_k8/libabsl_Sstrings_Slibstrings.so: error: undefined reference to '__muloti4'
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

looking...

smukherj1 commented 4 years ago

Ignoring the ubsan failure for now to unblock the configs release. Will discuss triaging the ubsan failure within our team later

veblush commented 3 years ago

@smukherj1 I just hit this issue when trying to update abseil in gRPC. Do you have a progress on this?

veblush commented 3 years ago

I solved this issue by replacing --copt=-fsanitize=undefined with --copt=-fsanitize-link-c++-runtime for the option of ubsan. (ref: https://github.com/grpc/grpc/pull/25805/commits/f5b07f849d8e149cc481c2f5413de9dd3a381aea)