(docu) clarify if openjdk-11 is expected to work

martinxyz commented 4 years ago

Description of the problem / feature request:

I'm bootstrapping on ARM/aarch64 because there are no binaries. The Bootstrapping docu claims:

You must install version 8 of the JDK. Versions other than 8 are not supported.

Debian (Buster) has no packages for JDK 8 (for aarch64), so I installed openjdk-11 instead. It seems to work fine.

This would be great to know in advance. The docu implies that my only option is to build JDK8 first, which would be quite an extra step.

It also claims that I need:

EXTRA_BAZEL_ARGS="--host_javabase=@local_jdk//:jdk"

which I've omitted. The build was successful.

What operating system are you running Bazel on?

Linux (aarch64, Debian Buster)

What's the output of `bazel info release`?

release 3.1.0- (@non-git)

If `bazel info release` returns "development version" or "(@non-git)", tell us how you built Bazel.

Downloaded the .zip and ran ./compile.sh with no arguments.

What's the output of `git remote get-url origin ; git rev-parse master ; git rev-parse HEAD` ?

not a git repository

aiuto commented 4 years ago

I think the docs are just out of date. If tests are passing with the new version you won.

martinxyz commented 4 years ago

I've tried to run the tests with:

./compile.sh all

It told me it was successful, but I didn't see if it actually ran any tests. (I know about bazel since, like, two hours now, so...)

~/bazel-3.1.0-dist$ file bazel-testlogs
bazel-testlogs: broken symbolic link to /tmp/bazel_t5SS59Xi/out/execroot/io_bazel/bazel-out/aarch64-opt/testlogs

Anyway, I'm now trying to compile ray with it, which seems to work. (with some select({}) errors with missing aarch64 cases, but that's another story)

philwo commented 3 years ago

Yes, openjdk-11 is fine. We'll update the docs.

bazelbuild / bazel