search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.07k stars 4.04k forks source link

Documentation issue: struct: proto.encode_text #12872

Open cvrebert opened 3 years ago

cvrebert commented 3 years ago

Documentation URL: https://docs.bazel.build/versions/master/skylark/lib/struct.html#to_proto

Deprecated: use proto.encode_text(x) instead.

It's not clear what proto refers to here. AFAIK, there's no Starlark built-in named proto, and this cross-reference isn't hyperlinked to documentation for a Starlark library.

benjaminp commented 3 years ago

https://docs.bazel.build/versions/master/skylark/lib/ProtoModule.html

brandjon commented 3 years ago

Looks like it needs a cross-reference, but yes, there now is a top-level proto module intended to replace struct.to_proto.

github-actions[bot] commented 6 months ago

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

cvrebert commented 6 months ago

Still a problem. Looks like https://bazel.build/rules/lib/toplevel/proto#encode_text would be the current relevant link to point to?