testdata/runfiles_test/MODULE.mock pins to its own rules_cc rather than following the top level bazel choice

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system

https://bazel.build

Apache License 2.0

22.77k stars 3.99k forks source link

testdata/runfiles_test/MODULE.mock pins to its own rules_cc rather than following the top level bazel choice #16029

Open aiuto opened 1 year ago

aiuto commented 1 year ago

Description of the bug:

src/test/py/bazel/testdata/runfiles_test/WORKSPACE.mock uses an ancient commit from rules_cc. https://github.com/bazelbuild/rules_cc/commit/8bd6cd75d03c01bb82561a96d9c1f9f7157b13d0

We should generate this file from distdir_deps.bzl using gen_workspace_stanza. That will align the tests using this declaration with the other integration tests that use the rules_cc we build with.

The same problem exists in

src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_remote_tools.WORKSPACE
tools/test/extensions.bzl

github-actions[bot] commented 6 months ago

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

aiuto commented 6 months ago

It is not really stale. The problem is that the test is still hand pinned to a rules_cc version. What we need is a way to automatically have the test cases track the top level dependency choices. We should do something like build the MODULE file for the test from the top level one.