Stop using absl flags in python based helpers

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system

https://bazel.build

Apache License 2.0

22.99k stars 4.03k forks source link

Stop using absl flags in python based helpers #16882

Open aiuto opened 1 year ago

aiuto commented 1 year ago

Technical debt

We depend on absl flags instead of argparse in many android helpers. We could switch to argparse to reduce footprint.

[x] tools/build_defs/pkg/build_tar.py
[ ] tools/android/incremental_install.py
[ ] tools/android/strip_resources.py
[ ] tools/android/instrumentation_test_check.py
[ ] tools/android/aar_embedded_jars_extractor.py
[ ] tools/android/aar_resources_extractor.py
[ ] tools/android/aar_embedded_proguard_extractor.py
[ ] tools/android/build_split_manifest.py
[ ] tools/android/stubify_manifest.py
[ ] tools/android/aar_native_libs_zip_creator.py
[ ] tools/aquery_differ/aquery_differ.py
[x] tools/jdk/proguard_whitelister.py
[ ] tools/ctexplain/ctexplain.py

idanakav commented 1 year ago

Apart from tech debt, I'm noticing an issue as well in tools/android/incremental_install.py after parsing the extra_adb_arg will end up with duplicated values if they are read from a flagfile.

limdor commented 1 year ago

Is it limited to these files? I'm asking because I saw is used in scripts/generate_fish_completion.py I created a PR for it https://github.com/bazelbuild/bazel/pull/18407

limdor commented 1 year ago

I pushed a second commit for scripts/docs/create_release_docs.py

aiuto commented 1 year ago

Is it limited to these files? It only pays back the effort if done in the helpers. That reduces the size of the Bazel image and eliminates one runtime dependency.

github-actions[bot] commented 2 months ago

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.