search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.06k stars 4.04k forks source link

'file:' scheme URLs are sent through --experimental_remote_downloader #17771

Closed gregjacobs closed 1 month ago

gregjacobs commented 1 year ago

Description of the bug:

I'm using Aspect's rules_js, and they've made recent changes where they're using repository_ctx.download() to handle local files using the file: scheme. (According to the comment, they've added this to handle binary files.)

However, even though it's a local file:-scheme URL, this ends up going through the --experimental_remote_downloader

Their snippet of code:

def _copy_input_file(priv, rctx, label_store, key):
    # ...

    # use rctx.download to copy the file instead of rctx.read + rctx.file so that
    # binary files are handled correctly
    rctx.download(
        output = label_store.repository_path(key),
        url = "file:" + label_store.path(key),
    )

Normally this works as expected, but when used in conjunction with --experimental_remote_downloader, the local file: scheme requests are going to our remote downloader service which sits on a remote machine (and therefore, of course, wouldn't have access to the host machine's local files).

I created an issue on their repo here: https://github.com/aspect-build/rules_js/issues/916, but seems like this may be a Bazel bug.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Create a repository rule that tries to "download" a file: scheme URL, while having --experimental_remote_downloader in use. Bazel will delegate to the remote downloader to attempt to "download" the local file.

It seems that file: scheme URLs should not go to the remote downloader, and should instead always be handled by the local downloader.

Which operating system are you running Bazel on?

MacOS Monterrey

What is the output of bazel info release?

release 6.0.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

Even with --experimental_remote_downloader_local_fallback (which somewhat works around the problem), we're still slowing down builds by making requests for all of these local files and we get warnings with long stack traces for each local file that is passed to the remote downloader. Example:

WARNING: Remote Cache: UNAVAILABLE: asset not available: file:/Users/user/project/pnpm-lock.yaml
io.grpc.StatusRuntimeException: UNAVAILABLE: asset not available: file:/Users/user/project/pnpm-lock.yaml
    at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
    at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
    at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
    at build.bazel.remote.asset.v1.FetchGrpc$FetchBlockingStub.fetchBlob(FetchGrpc.java:396)
    at com.google.devtools.build.lib.remote.downloader.GrpcRemoteDownloader.lambda$download$0(GrpcRemoteDownloader.java:135)
    at com.google.devtools.build.lib.remote.ReferenceCountedChannel.lambda$withChannelBlocking$2(ReferenceCountedChannel.java:85)
    at com.google.devtools.build.lib.remote.ReferenceCountedChannel.lambda$withChannel$4(ReferenceCountedChannel.java:108)
    at io.reactivex.rxjava3.internal.operators.single.SingleUsing.subscribeActual(SingleUsing.java:59)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleFlatMap$SingleFlatMapCallback.onSuccess(SingleFlatMap.java:85)
    at io.reactivex.rxjava3.internal.operators.single.SingleFlatMap$SingleFlatMapCallback$FlatMapSingleObserver.onSuccess(SingleFlatMap.java:112)
    at io.reactivex.rxjava3.internal.operators.single.SingleMap$MapSingleObserver.onSuccess(SingleMap.java:65)
    at io.reactivex.rxjava3.internal.operators.single.SingleDoOnDispose$DoOnDisposeObserver.onSuccess(SingleDoOnDispose.java:84)
    at io.reactivex.rxjava3.internal.operators.single.SingleDoOnError$DoOnError.onSuccess(SingleDoOnError.java:52)
    at io.reactivex.rxjava3.internal.operators.observable.ObservableSingleSingle$SingleElementObserver.onComplete(ObservableSingleSingle.java:110)
    at io.reactivex.rxjava3.internal.observers.DeferredScalarDisposable.complete(DeferredScalarDisposable.java:85)
    at io.reactivex.rxjava3.subjects.AsyncSubject.subscribeActual(AsyncSubject.java:233)
    at io.reactivex.rxjava3.core.Observable.subscribe(Observable.java:13176)
    at io.reactivex.rxjava3.internal.operators.observable.ObservableSingleSingle.subscribeActual(ObservableSingleSingle.java:36)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleDoOnError.subscribeActual(SingleDoOnError.java:35)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleDoOnDispose.subscribeActual(SingleDoOnDispose.java:38)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleMap.subscribeActual(SingleMap.java:35)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleFlatMap$SingleFlatMapCallback.onSuccess(SingleFlatMap.java:85)
    at io.reactivex.rxjava3.internal.operators.single.SingleCreate$Emitter.onSuccess(SingleCreate.java:68)
    at com.google.devtools.build.lib.remote.grpc.TokenBucket$1.onNext(TokenBucket.java:79)
    at io.reactivex.rxjava3.internal.util.NotificationLite.accept(NotificationLite.java:247)
    at io.reactivex.rxjava3.subjects.BehaviorSubject$BehaviorDisposable.test(BehaviorSubject.java:507)
    at io.reactivex.rxjava3.subjects.BehaviorSubject$BehaviorDisposable.emitFirst(BehaviorSubject.java:468)
    at io.reactivex.rxjava3.subjects.BehaviorSubject.subscribeActual(BehaviorSubject.java:224)
    at io.reactivex.rxjava3.core.Observable.subscribe(Observable.java:13176)
    at com.google.devtools.build.lib.remote.grpc.TokenBucket.lambda$acquireToken$0(TokenBucket.java:64)
    at io.reactivex.rxjava3.internal.operators.single.SingleCreate.subscribeActual(SingleCreate.java:40)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleFlatMap.subscribeActual(SingleFlatMap.java:37)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleDefer.subscribeActual(SingleDefer.java:43)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.internal.operators.single.SingleFlatMap.subscribeActual(SingleFlatMap.java:37)
    at io.reactivex.rxjava3.core.Single.subscribe(Single.java:4855)
    at io.reactivex.rxjava3.core.Single.blockingGet(Single.java:3644)
    at com.google.devtools.build.lib.remote.ReferenceCountedChannel.withChannelBlocking(ReferenceCountedChannel.java:85)
    at com.google.devtools.build.lib.remote.downloader.GrpcRemoteDownloader.lambda$download$1(GrpcRemoteDownloader.java:132)
    at com.google.devtools.build.lib.remote.Retrier.execute(Retrier.java:244)
    at com.google.devtools.build.lib.remote.RemoteRetrier.execute(RemoteRetrier.java:125)
    at com.google.devtools.build.lib.remote.RemoteRetrier.execute(RemoteRetrier.java:114)
    at com.google.devtools.build.lib.remote.downloader.GrpcRemoteDownloader.download(GrpcRemoteDownloader.java:130)
    at com.google.devtools.build.lib.bazel.repository.downloader.DelegatingDownloader.download(DelegatingDownloader.java:62)
    at com.google.devtools.build.lib.bazel.repository.downloader.DownloadManager.download(DownloadManager.java:258)
    at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkBaseExternalContext.download(StarlarkBaseExternalContext.java:484)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
    at java.base/java.lang.reflect.Method.invoke(Unknown Source)
    at net.starlark.java.eval.MethodDescriptor.call(MethodDescriptor.java:162)
    at net.starlark.java.eval.BuiltinFunction.fastcall(BuiltinFunction.java:77)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Eval.evalCall(Eval.java:682)
    at net.starlark.java.eval.Eval.eval(Eval.java:497)
    at net.starlark.java.eval.Eval.exec(Eval.java:271)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFunctionBody(Eval.java:66)
    at net.starlark.java.eval.StarlarkFunction.fastcall(StarlarkFunction.java:173)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Eval.evalCall(Eval.java:682)
    at net.starlark.java.eval.Eval.eval(Eval.java:497)
    at net.starlark.java.eval.Eval.exec(Eval.java:271)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execIf(Eval.java:205)
    at net.starlark.java.eval.Eval.exec(Eval.java:283)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFor(Eval.java:126)
    at net.starlark.java.eval.Eval.exec(Eval.java:276)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFunctionBody(Eval.java:66)
    at net.starlark.java.eval.StarlarkFunction.fastcall(StarlarkFunction.java:173)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Eval.evalCall(Eval.java:682)
    at net.starlark.java.eval.Eval.eval(Eval.java:497)
    at net.starlark.java.eval.Eval.exec(Eval.java:271)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFunctionBody(Eval.java:66)
    at net.starlark.java.eval.StarlarkFunction.fastcall(StarlarkFunction.java:173)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Eval.evalCall(Eval.java:682)
    at net.starlark.java.eval.Eval.eval(Eval.java:497)
    at net.starlark.java.eval.Eval.exec(Eval.java:271)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFunctionBody(Eval.java:66)
    at net.starlark.java.eval.StarlarkFunction.fastcall(StarlarkFunction.java:173)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Eval.evalCall(Eval.java:682)
    at net.starlark.java.eval.Eval.eval(Eval.java:497)
    at net.starlark.java.eval.Eval.execAssignment(Eval.java:109)
    at net.starlark.java.eval.Eval.exec(Eval.java:268)
    at net.starlark.java.eval.Eval.execStatements(Eval.java:82)
    at net.starlark.java.eval.Eval.execFunctionBody(Eval.java:66)
    at net.starlark.java.eval.StarlarkFunction.fastcall(StarlarkFunction.java:173)
    at net.starlark.java.eval.Starlark.fastcall(Starlark.java:638)
    at net.starlark.java.eval.Starlark.call(Starlark.java:604)
    at com.google.devtools.build.lib.bazel.repository.starlark.StarlarkRepositoryFunction.fetch(StarlarkRepositoryFunction.java:220)
    at com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction.fetchRepository(RepositoryDelegatorFunction.java:413)
    at com.google.devtools.build.lib.rules.repository.RepositoryDelegatorFunction.compute(RepositoryDelegatorFunction.java:344)
    at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:571)
    at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:382)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
    at java.base/java.lang.Thread.run(Unknown Source)

If it's not possible to change the behavior of file: scheme URLs going to the remote downloader at this point though, perhaps there needs to be another flag added, something like --experimental_remote_downloader_file_scheme_local (or something of the sort - naming is hard :))

meisterT commented 1 year ago

cc @Wyverald

github-actions[bot] commented 4 months ago

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

github-actions[bot] commented 1 month ago

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please post @bazelbuild/triage in a comment here and we'll take a look. Thanks!