search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.13k stars 4.05k forks source link

`worker_extra_flags` not passed through to remote persistent workers #18138

Open vaibhav-shah opened 1 year ago

vaibhav-shah commented 1 year ago

Description of the bug:

worker_extra_flag works locally, but the supplied flags are not passed to the remote worker.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Pavank1992 commented 1 year ago

Hi @vaibhav-shah, Could you please share minimal step to produce the issue with sample code?

larsrc-google commented 1 year ago

http://google3/third_party/bazel/src/main/java/com/google/devtools/build/lib/remote/RemoteExecutionService.java;l=524;rcl=526500829 handles the extra info the WorkerKey, but doesn't update the args AFAICT.

larsrc-google commented 1 year ago

@benjaminp Any thoughts on whether this is feasible?

benjaminp commented 1 year ago

There would have to be a remote protocol change to allow the extra worker flags to be passed to the executor.