Incompatible: Remove legacy allowlist names

[comius]

The change removes legacy _whitelist_function_transition.

First merged and rolled back: https://github.com/bazelbuild/bazel/commit/10a46b1e85f0b5bf8564c125dd02cd4e70017452

The naming is in use in old rules_go, which several projects haven't upgraded.

[comius]

Help needed:

• rules_jsonnet breakage : https://github.com/bazelbuild/rules_jsonnet/issues/173
  • https://github.com/bazelbuild/rules_jsonnet/pull/174
  • PR is failing on go_dependency, help needed

Pending fixes:

• Bazelisk: breakage: https://github.com/bazelbuild/bazelisk/issues/497
  • fix pending: https://github.com/bazelbuild/bazelisk/pull/498
• Bazel skylib: breakage https://github.com/bazelbuild/bazel-skylib/issues/459
  • preexisting failure, build failing at head: https://github.com/bazelbuild/bazel-skylib/issues/458
  • fix pending: https://github.com/bazelbuild/bazel-skylib/pull/460

Fixed (not verified):

• rules_sass breakage: https://github.com/bazelbuild/rules_sass/issues/151
  • https://github.com/bazelbuild/rules_sass/pull/152
• FlatBuffers: breakage: https://github.com/google/flatbuffers/issues/8091
  • https://github.com/google/flatbuffers/pull/8092
• rules_python: breakage: https://github.com/bazelbuild/rules_python/issues/1409
  • fix pending: https://github.com/bazelbuild/rules_python/pull/1410
• rules_dotnet breakage: https://github.com/bazelbuild/rules_dotnet/issues/375
  • https://github.com/bazelbuild/rules_dotnet/pull/376
  • • rules_android: breakage: https://github.com/bazelbuild/rules_android/issues/134
  • will resolve when build is fixed at head:
  • rules_cc: breakage: https://github.com/bazelbuild/rules_cc/issues/19
  • fix pending internally
• rules_closure: breakage: https://github.com/bazelbuild/rules_closure/issues/586
  • https://github.com/bazelbuild/rules_closure/pull/587

rules_docker was archived:

• rules_docker has preexisting problem: https://github.com/bazelbuild/rules_docker/issues/1988
  • Help/investigation needed with rules_docker/gazelle: Error: file '@bazel_tools//tools/build_defs/repo:utils.bzl' does not contain symbol 'read_user_netrc', happening in gazelle repo (see https://buildkite.com/bazel/rules-docker-docker/builds/6976#018a887a-ad48-4d05-b73a-31a4b12a515a)

Buildfarm depends on rules_docker:

• Buildfarm: breakage: https://github.com/bazelbuild/bazel-buildfarm/issues/1440
  • rules_go coming from rules_docker: https://github.com/bazelbuild/rules_docker/pull/2273

[comius]

cc @fmeum

[comius]

One month has passed, without maintainers upgrading rules_go. So I believe we can roll forward the change again.

[fmeum]

@comius Would you be supportive of a change to remove the allowlist attribute requirement for Bazel, for example via a flag that is unflipped within Google via a .blazerc line? I have never seen anyone specify a non-trivial package_group outside Google, especially not in publicly available rulesets.

[comius]

Actually I was thinking to change the implementation so that attribute is automatically added when there’s a transition.

The only problem is that I’d need it to either always point to @bazel_tools (simple) or add a flag to configure where it should point.

[comius]

Cc @gregestren

[fmeum]

If users do want to point it to a non-standard location, could they still explicitly add the attribute? If that is the case, then having it always point into @bazel_tools when it is added automatically sounds fine to me.

[gregestren]

I support removing the requirement from Bazel, whatever the implementation (both sound fine to me).

[comius]

Ack. Working on the implementation.

[fmeum]

@bazel-io flag

[fmeum]

@iancha1992 Could https://github.com/bazelbuild/bazel/commit/bb7fb2d32f055f2a70a5ab394cf5aef29bc74b2e be marked for cherry-picking to 7.0.0?

[iancha1992]

@bazel-io fork 7.0.0