bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
22.91k stars 4.02k forks source link

bazel test --noenable_runfiles creates runfiles symlinks on linux #22856

Open peakschris opened 2 months ago

peakschris commented 2 months ago

Description of the bug:

I've noticed a difference in behaviour between windows and linux when the --noenable_runfiles flag is explicitly specified on both platforms.

Windows: bazel test <target> --noeenable_runfiles does not create runfiles symlinks Linux: bazel test <target> --noenable_runfiles does create runfiles symlinks

The linux behaviour of bazel test is different to bazel run. bazel run <target> --noenable_runfiles behaves as I would expect and does not create symlinks.

Is this expected? If not, I can create a minimal reproducer.

Thanks!

Which category does this issue belong to?

Local Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

TBD, will share if needed

Which operating system are you running Bazel on?

windows and linux

What is the output of bazel info release?

7.1.2 and 7.2.0, same behaviour

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

fmeum commented 2 months ago

My understanding is that this is expected but not desired: The Unix test runner simply needs directory-based runfiles to function.

peakschris commented 2 months ago

@fmeum ok, that's understandable. Is this something that can be fixed? In the meantime, could a warning be emitted if trying to run tests on linux with --noenable_runfiles set?

meisterT commented 1 month ago

cc @lberki