search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
22.71k stars 3.98k forks source link

Prebuilt java_tools should have a filegroup that includes zipper #22889

Open timothyg-stripe opened 2 weeks ago

timothyg-stripe commented 2 weeks ago

Prebuilt java_tools zip files include the zipper binary:

❯ curl -L https://github.com/bazelbuild/java_tools/releases/download/java_13.6.1/java_tools_linux-v13.6.1.zip 2>/dev/null | tar -t | grep zipper
java_tools/ijar/zipper

This appears to be an intentional choice: https://github.com/bazelbuild/bazel/blob/4a5b5234349bc5cc822ee9093d7eefcaa32aa710/third_party/ijar/BUILD#L138-L143

But the BUILD file that comes with prebuilt java_tools doesn't have a filegroup with the zipper binary, so we can't directly reference it, which is unfortunate.

fmeum commented 2 weeks ago

I think that it lives under @bazel_tools//tools/zip.

timothyg-stripe commented 2 weeks ago

@fmeum @bazel_tools//tools/zip:zipper/zipper is only the current platform's binary. Ideally we'd like access to all platforms.

hvadehra commented 5 days ago

@timothyg-stripe Do you have a usecase that specifically needs ijar's zipper tool?

See https://github.com/bazelbuild/bazel/issues/19446