search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
22.71k stars 3.98k forks source link

Support `META-INF/spring.factories` merging in singlejar tool #22908

Open guw opened 1 week ago

guw commented 1 week ago

Description of the feature request:

The singlejar tool has special support for some Spring files but lacks support for merging META-INF/spring.factories files. The challenge for merging these files is that it is a properties file and entries for the same key needs to be merged into a list (separated by comma).

Which category does this issue belong to?

Java Rules

What underlying problem are you trying to solve with this feature?

Merging jars with multiple such files.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

7.2.1

Have you found anything relevant by searching the web?

hvadehra commented 3 days ago

I think this a special case of the more general FR here: https://github.com/bazelbuild/bazel/issues/7330 which has come up several different times. We should definitely look into a general-purpose design/fix.

However as there is already some pre-existing support for spring, fixing this issue could be relatively simpler. But I'll defer to @cushon on whether we wan't to go down that path.