bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.24k stars 4.08k forks source link

Starlark flags are omitted from BEP "explicit command line" #23514

Open tpudlik opened 2 months ago

tpudlik commented 2 months ago

Description of the bug:

Starlark flags (like label_flag) are omitted from the explicitCmdLine provided via BEP, even when they are in fact explicitly provided by the user on the command line.

This is inconvenient because the user should be able to copy-paste the explicit command line to reproduce the build, but that obviously requires setting the Starlark flags, too!

See https://github.com/buildbuddy-io/buildbuddy/issues/7361 for more context.

Which category does this issue belong to?

Configurability, Remote Execution

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

8.0.0-pre.20240618.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

meisterT commented 2 months ago

cc @michaeledgar

aranguyen commented 1 month ago

@fmeum I'm triaging the issues for the team and notice you mentioned a potential fix is this still in your plan? I'm aware you also mentioned the fix is more involved than expected