bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.21k stars 4.06k forks source link

regard some errors as fatal even if --keep_going supplied #23847

Open peakschris opened 1 month ago

peakschris commented 1 month ago

Description of the bug:

We use --keep_going in some cases to collect a full set of build errors - it can be quicker to fix a set of build errors in one go rather than one-by-one. However, for some error states (such as no space left on device) it isn't helpful to keep going, and we would prefer that bazel immediately stops.

This is a request to consider some errors as fatal and stop immediately, even when --keep_going is supplied.

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run a build with no disk space and --keep_going

Which operating system are you running Bazel on?

windows

What is the output of bazel info release?

7.3.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

If this is a regression, please try to identify the Bazel commit where the bug was introduced with bazelisk --bisect.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

joeleba commented 2 weeks ago

We already have this feature for some catastrophic errors e.g. when there's an IllegalStateException.