Artifact debug repr should include the owner

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system

https://bazel.build

Apache License 2.0

23k stars 4.03k forks source link

Artifact debug repr should include the owner #6272

Open benjaminp opened 5 years ago

benjaminp commented 5 years ago

As of bf4123df23b5f93e572cd920f15afba340f92391, Artifact equality takes the artifact owner into account. Since the Starlark repr of Artifact only prints the execpath, it's possible to have two artifacts, a and b, that have the same execpath (and thus repr) but satisfy a != b. Unsurprisingly, this generates confusion–even for seasoned Blaze developers. Therefore, I propose including the owner in the output of printing an artifact.

aiuto commented 5 years ago

Assigning to configurability for now, this might be Execution.

jin commented 5 years ago

Reassigning to Starlark, since this is about repr().

brandjon commented 5 years ago

+1, appears to have hit me in #7655.

Edit: meant to reply on #7658, not this bug, but this is problematic for similar reasons.