search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.23k stars 4.07k forks source link

Release 0.25 - April 2019 #7498

Closed laurentlb closed 5 years ago

laurentlb commented 5 years ago

Target RC date: April 1st

dkelmer commented 5 years ago

@laurentlb, no. I can send an email to bazel-discuss@. What do you mean by sending an announcement to the blog?

jin commented 5 years ago

@dkelmer @iirina you can ignore https://github.com/bazelbuild/bazel/issues/7498#issuecomment-489286392 - fixed by bumping rules_scala.

dkelmer commented 5 years ago

fix to https://github.com/bazelbuild/bazel/issues/8236 also needs to be included in the patch release

dkelmer commented 5 years ago

Command to create 0.25.1rc3 scripts/release/release.sh create --force_rc=3 0.25.1 f44bc4732650f6ad011407cc5c41cb36de23acdb ed48a4a5fddbd93b057c3aa726e15720d79dcf8f 81aefe7ee01cc73646a53f9c72ed40ead09f9f5a

Note that first commit is the 0.25.0 release, the second is a local commit, and the 3rd is a public commit

dkelmer commented 5 years ago

Patch release 0.25.1 has been released https://github.com/bazelbuild/bazel/releases/tag/0.25.1

petemounce commented 5 years ago

Pushed to chocolatey.

jin commented 5 years ago

The Android emulator team recently pushed a new stable emulator release that removed some files that Bazel's Android SDK BUILD template looks for (emulator64-x86 and emulator64-arm). Because of this, all Bazel versions will fail when trying to test android_instrumentation_test targets or run android_device rules. The problem is that there is no way for users to download an older version of the emulator from Android Studio or the sdkmanager command line, so users who update their Android emulators will see this breakage with no workaround.

https://github.com/bazelbuild/bazel/issues/8280

This affects all Bazel versions, and has already been cherry-picked into 0.26.0rc7. Can we cherry-pick the fix to 0.25 too? The fix is here: https://github.com/bazelbuild/bazel/commit/85a5a2bd569a5274950fc7327a044c395248c024

cc @meteorcloudy

dkelmer commented 5 years ago

This is an interesting case because it's not a Bazel breakage, but I do think that it makes sense for the most recent version of Bazel to be able to build an android_device so I'll create a patch release (we can't cherry pick PRs into an existing release). But to clarify: there's no way the emulator auto updates, right? And so is it not possible that some people will still have an older version of the emulator image? Once https://github.com/bazelbuild/bazel/commit/85a5a2bd569a5274950fc7327a044c395248c024 is cherry picked, won't that mean that the patch release won't work with those older emulators?

jin commented 5 years ago

The emulator will not automatically update, but new SDK downloads will use the new emulator. The patch is also backwards compatible with older emulator versions.

dkelmer commented 5 years ago

Backwards compatible is what I wanted to hear ;) Starting the patch release process now

dkelmer commented 5 years ago

Also adding the fix to https://github.com/bazelbuild/bazel/issues/8254 to the patch release

dkelmer commented 5 years ago

To create 0.25.2:

scripts/release/release.sh create --force_rc=2 0.25.2 582b79ef3e2c9c9ae1878eedd2771df11c5f6061 0900660d67b53a56a13d1fa16a788e4cecbb1c0e 85a5a2bd569a5274950fc7327a044c395248c024

buchgr commented 5 years ago

The fix for this will require a patch release, as the bug effectively causes an an infinite loop for remote execution: https://github.com/bazelbuild/bazel/issues/8320

dkelmer commented 5 years ago

Created 0.25.3 scripts/release/release.sh create 0.25.3 318aebb523b3c91275855e35f0a67814e0d2231f 0ff19c6d0adf3c0df94fff59ca3bd13cbcf99897

petemounce commented 5 years ago

I tried to create the 0.25.3 chocolatey package, but https://github.com/bazelbuild/bazel/releases/tag/0.25.3 does not exist yet?

dkelmer commented 5 years ago

@petemounce, that is correct. I'm pushing it now. There was an issue that has been resolved.