search

bazelbuild / bazel

a fast, scalable, multi-language and extensible build system
https://bazel.build
Apache License 2.0
23.21k stars 4.07k forks source link

Test infrastructure for query of Starlark-defined rules and aspects #9354

Open c-parsons opened 5 years ago

c-parsons commented 5 years ago

We have some gaps in test coverage pertaining to Starlark-defined rules and aspects, namely we do not have tests that verify that bazel query operates correctly on them.

For example, we should have a test that verifies, if we that a Starlark rule my_rule which attaches a Starlark-defined aspect my_aspect along its deps attribute, that, for a rule target //package:x of my_rule:

bazel query "deps(//package:x)"

contains the transitive deps of //package:x as well as the transitive deps of my_aspect (which may have implicit dependencies on other targets)

comius commented 1 year ago

I think I saw test coverage for this, but I need to verify.

github-actions[bot] commented 2 weeks ago

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.