search

bazelbuild / bazelisk

A user-friendly launcher for Bazel.
Apache License 2.0
2.05k stars 316 forks source link

Add OS-specific BAZELISK_HOME #474

Closed mzapotoczny closed 3 weeks ago

mzapotoczny commented 1 year ago

BAZELISK_HOME should be set as absolute path, but all supported OSes use different folder structure. This might be a problem if we want to globally set BAZELISK_HOME for all developers.

Therefore we want to propose a change to add support for OS-specific BAZELISK_HOME, for example BAZELISK_HOME_WINDOWS.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mzapotoczny commented 1 year ago

@fweikert could you take a look? Thanks in advance :)

McAmun commented 10 months ago

@fweikert - could you please have a look on that change ?

McAmun commented 7 months ago

@katre can you maybe help here ?

McAmun commented 2 months ago

@fweikert any update on this ?

McAmun commented 4 weeks ago

@fweikert @meteorcloudy - Can we get this merged please ? We would like to start using your official releases.

fweikert commented 3 weeks ago

@mzapotoczny thanks for this change, I took the liberty of resolving the merge conflict.