search

bazelbuild / bazelisk

A user-friendly launcher for Bazel.
Apache License 2.0
1.96k stars 302 forks source link

Remove rules_go as deps #486

Closed wisechengyi closed 10 months ago

wisechengyi commented 11 months ago

Problem / Solution

In theory bazelisk should not depend on rules_go, and indeed after a go mod tidy, rules_go went away.

I searched around and didn't find too much context why rules_go was added.

google-cla[bot] commented 11 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

sluongng commented 11 months ago

It was added in https://github.com/bazelbuild/bazelisk/commit/70eecfe6f2b3f0c821f77faae70f231bb3239286 by @philwo. Looks like it's not needed 🤔

wisechengyi commented 11 months ago

Hi @fweikert would you kindly see if this is merge-able?

philwo commented 10 months ago

Mhm, yeah. Strange. I also can't really say why it would be needed. Removing it LGTM and we'll find out if something breaks ;)