search

bazelbuild / bazelisk

A user-friendly launcher for Bazel.
Apache License 2.0
2.05k stars 316 forks source link

Bazelisk 1.18 doesn't handle WORKSPACE-less repositories #514

Closed katre closed 10 months ago

katre commented 10 months ago

I spent a while this weekend trying to figure out why a new project, which had a MODULE.bazel file (and a WORKSPACE.bzlmod), but no WORKSPACE file, was having the .bazelversion file ignored.

After some debugging I realized that bazelisk 1.18.0 only looks for .bazelversion in the repository root, and identifies the repository root by the presence of a WORKSPACE file.

Looks like this was fixed in b7f5c7570df35ce2273afa0c15f4bc5038fb126a, but we should cut a new Bazelisk release with that commit before Bazel 7.0 is released.

brentleyjones commented 10 months ago

@fweikert can we get a new release? 🙏

crncnnr commented 10 months ago

I would also appreciate a new release, please!

fweikert commented 10 months ago

https://github.com/bazelbuild/bazelisk/releases/tag/v1.19.0