bazelbuild / bazelisk

A user-friendly launcher for Bazel.
Apache License 2.0
1.95k stars 300 forks source link

Bazelisk pulls incorrect Bazel on Windows ARM64 #572

Open jxy-s opened 2 months ago

jxy-s commented 2 months ago

The x64 version of bazelisk is compatible with a Windows ARM64 machine, it will run under x64 emulation on Windows. However it ends up pulling the x64 version of Bazel which causes unintended downstream behavior.

Bazelisk should pull the ARM64 version of when running on Windows ARM64 instead of the x64 version.

See: https://github.com/bazelbuild/bazel/issues/22164#issuecomment-2081383179

meteorcloudy commented 1 month ago

This is probably because we don't have windows arm64 binary for bazelisk itself. @fweikert Do you know how hard it would be to add? We cross-compile all binaries with the go toolchain anyway, right?

meteorcloudy commented 1 month ago

Maybe it's as simple as adding another target for windows arm64 here? https://github.com/bazelbuild/bazelisk/blob/47f60477721681a117cbf905784ee5220100e68b/BUILD#L145-L153