search

bazelbuild / buildtools

A bazel BUILD file formatter and editor
Apache License 2.0
1.01k stars 415 forks source link

Cover missing cases during module extension label normalization #1219

Closed fmeum closed 1 month ago

fmeum commented 10 months ago

The previous logic missed to normalize cases such as "extension.bzl" and ":extension.bzl". Instead of enumerating cases, parse the label and track it in canonical form.

Related to https://github.com/bazelbuild/bazel/pull/20482

fmeum commented 10 months ago

CC @Wyverald

larsrc-google commented 9 months ago

Sorry, not familiar with this code base nor with Go.

fmeum commented 9 months ago

This is running into the same kind of likely unrelated CI failures on Windows as my other PR.

fmeum commented 6 months ago

@vladmos Friendly ping

fmeum commented 5 months ago

@vladmos Friendly ping

fmeum commented 1 month ago

@vladmos Friendly ping