search

bazelbuild / buildtools

A bazel BUILD file formatter and editor
Apache License 2.0
1.01k stars 415 forks source link

Fixes build for Windows #1230

Closed meteorcloudy closed 8 months ago

meteorcloudy commented 8 months ago

Fixes https://github.com/bazelbuild/buildtools/issues/1210

meteorcloudy commented 8 months ago

Not as simple as I thought..

meteorcloudy commented 8 months ago

Turns out it's a long path issue on Windows.

meteorcloudy commented 8 months ago

After this one, we still need to update rules_go to fix downstream breakage: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3592#018d0add-494c-4c59-b452-da6cd582688c

meteorcloudy commented 8 months ago

@vladmos Can you please try to update rules_go to fix the breakage with Bazel@HEAD?

(04:01:30) ERROR: Traceback (most recent call last):
    File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/private/rules/transition.bzl", line 126, column 47, in _go_transition_impl
        platform = platform_from_crosstool(crosstool_top, cpu)
    File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/platform/crosstool.bzl", line 57, column 27, in platform_from_crosstool
        platform = matcher(crosstool_top, cpu)
    File "/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9e21fb089b9da2ba3a2c9233fa8beaa3/external/io_bazel_rules_go/go/platform/crosstool.bzl", line 38, column 21, in _match_android
        crosstool_top.workspace_name == "androidndk":
Error: 'NoneType' value has no field or method 'workspace_name'
vladmos commented 8 months ago

@meteorcloudy Updated in #1234