search

bazelbuild / buildtools

A bazel BUILD file formatter and editor
Apache License 2.0
1.01k stars 415 forks source link

buildozer: handle multiple glob tokens in set command #1250

Open stagnation opened 6 months ago

stagnation commented 6 months ago

To address #1249. This continues the special case handling for globs in set X glob(...) commands from #100. Ideally we should have a higher parsing level to extract the inner arguments from functions so they can be reorganized like regular files are. This does not work for add X glob(...) which follows the status quo. At the moment we only use set internally but can look at add too on the back burner. Thanks for this wonderful tool!

stagnation commented 6 months ago

Just found this: https://github.com/bazelbuild/buildtools/pull/572 which also improves globs, higher up in the parser. Is that a better solution to revive and continue with?