search

bazelbuild / continuous-integration

Bazel's Continuous Integration Setup
https://buildkite.com
Apache License 2.0
258 stars 135 forks source link

Add Visual Stido 2019 to Windows runners #1204

Open UebelAndre opened 3 years ago

UebelAndre commented 3 years ago

Windows builds for rules_foreign_cc seem to be having issues on windows. A recent PR (https://github.com/bazelbuild/rules_foreign_cc/pull/757) runs into issues in this build: 

CMake Error at CMakeLists.txt:3 (project):
  Generator

    Visual Studio 15 2017

  could not find any instance of Visual Studio.

And by trying to update to a newer version Visual Studio (https://github.com/bazelbuild/rules_foreign_cc/pull/758) CI shows:

CMake Error at CMakeLists.txt:6 (project):
  Generator

    Visual Studio 16 2019

  could not find any instance of Visual Studio.

It'd be nice if a recent version of visual studio was installed. But I'll settle for whatever fixes CI 😄

philwo commented 3 years ago

Hi @UebelAndre!

Sorry for the issues here. Both versions of Visual Studio should be installed in the image: https://github.com/bazelbuild/continuous-integration/blob/c6ea70e31177600d96221f2fd409428995b65ef1/buildkite/setup-windows.ps1#L119-L129

I'm not sure why it's no longer working in our latest image.. :/ I'll investigate, but won't have time before Monday (taking tomorrow off and then it's the weekend).