search

bazelbuild / continuous-integration

Bazel's Continuous Integration Setup
https://buildkite.com
Apache License 2.0
258 stars 136 forks source link

Add PR hook for rules_jsonnet #53

Closed davidzchen closed 7 years ago

davidzchen commented 7 years ago

Currently, it seems that bazelbuild/rules_jsonnet is not being tested with Jenkins.

damienmg commented 7 years ago

@davidzchen Can you send a gerrit code review for it?

davidzchen commented 7 years ago

Sounds good. Though before I do so, I would like to make a change to rules_jsonnet to put examples and docs into sub-workspaces, similar to what we are doing with other rules repos, such as rules_rust. However, it looks like I first need to fix jsonnet.bzl because currently, I get an error when I try to build the examples when they are in their own workspace.

davidzchen commented 7 years ago

Sent the following review: https://bazel-review.googlesource.com/10310