search

bazelbuild / examples

Examples for Bazel
http://bazel.build
Apache License 2.0
824 stars 506 forks source link

Update to latest rules_kotlin #303

Open sgowroji opened 1 year ago

sgowroji commented 1 year ago

Fixes https://github.com/bazelbuild/examples/issues/301

Wyverald commented 1 year ago

looks like the android/jetpack-compose example is using an older Bazel version which doesn't support some of the new syntax. could we just remove https://github.com/bazelbuild/examples/blob/main/android/jetpack-compose/.bazelversion ?

meteorcloudy commented 1 year ago

@jin Can you help review this one?

meteorcloudy commented 1 year ago

@sgowroji Can you update android/jetpack-compose/.bazelversion to just last_green?

meteorcloudy commented 1 year ago

The test is still failing, does rules_kotlin 1.8 actually include the fix?

sgowroji commented 1 year ago

Waiting for rules_kotlin release https://github.com/bazelbuild/rules_kotlin/pull/1005#issuecomment-1705008876

meteorcloudy commented 1 year ago

@ted-xie Can you take a look at the failure, not sure what's missing.

ted-xie commented 1 year ago

Sorry to pass the buck, but @Bencodes probably knows the most about rules_kotlin, bazel's jetpack-compose support, and their interaction.

alexeagle commented 1 year ago

Hey @Bencodes I'm just doing a maintenance pass over the repo, is that something you can help with? 🙇🏻