search

bazelbuild / examples

Examples for Bazel
http://bazel.build
Apache License 2.0
800 stars 497 forks source link

chore: delete stale tutorial content #331

Closed alexeagle closed 8 months ago

alexeagle commented 9 months ago
  1. This contains an iOS app, but the main iOS tutorial linked from https://bazel.build/start/ios-app lives elsewhere
  2. It shows rules_appengine, but that repo appears to have only minimal maintenance for broken flags. Latest comment from a maintainer is 'not being actively maintained' https://github.com/bazelbuild/rules_appengine/issues/128#issuecomment-1194862052
  3. bazelbuild/codelabs was archived, but there are active community forks at https://github.com/engflow/codelabs and https://github.com/aspect-build/codelabs which have fresher content than this tutorials folder.
  4. No one has touched tutorial/android in four years.
BalestraPatrick commented 9 months ago

From rules_apple's side, we're okay with removing this since we already have a version of this tutorial which we maintain in rules_apple: https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md

gregestren commented 9 months ago

Re: Android, note https://bazel.build/start/android-app refers to this repo. Particularly examples/android/tutorial.

https://github.com/bazelbuild/examples/tree/main/android/tutorial is different than https://github.com/bazelbuild/examples/tree/main/tutorial/android ?

This looks reasonable to me but paging @ahumesky .

alexeagle commented 9 months ago

Correct, /android/tutorial should remain, /tutorial/android looks like dead code.

alexeagle commented 8 months ago

ping @gregestren could you ask Alex to look? I don't think he has setup notifications from GitHub or doesn't notice them.

alexeagle commented 8 months ago

ping @meisterT

ahumesky commented 8 months ago

Looks fine to remove redundant tutorials/samples/examples. Pretty confusing anyway to have both android/tutorial and tutorial/android