refactor: rename frontend to javascript and upgrade to rules_js 1.39.1

bazelbuild / examples

Examples for Bazel

http://bazel.build

Apache License 2.0

800 stars 497 forks source link

refactor: rename frontend to javascript and upgrade to rules_js 1.39.1 #430

Closed gregmagolan closed 2 months ago

gregmagolan commented 3 months ago

Should fix the flake seen in the frontend example CI caused by https://github.com/aspect-build/rules_js/issues/1412.

javascript is a better name for the folder IMO but the rename is also related to fixing the flake since it results in all repository rules in that directory being invalidated and re-run. The above flake is tied to when the repository rule executes and on persistent runners on Bazel CI just bumping the rules_js version is not sufficient to make that happen.

alexeagle commented 2 months ago

I think renaming this is too disruptive, the examples repo is VERY commonly used as a reference which means this rename breaks a lot of folks permalinks, in their "getting started" docs.