Closed tpasternak closed 2 months ago
Oh, I can't just test it properly with the current test framework, because it converts TestFileSystem
's files to NIO files via paths without hestitation, so as a result the tests would crash because it's impossible to call listFiles
on it. I removed the comment (as it's already commented in string) and I'll try to think about fixing the test framework later
That's fair, it's fine to leave the proper tests as a follow up. Do you think it would be hard to add a test that asserts that the section parses correctly? So a test that takes the string:
view_project_root: true
And asserts that the right Section is created.
Ok, that's easy, could you take a look again?
Yeah, looks good to me! Thanks for this change.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>
Description of this change
https://github.com/bazelbuild/intellij/assets/1066003/29720ae3-bc31-4b05-b9d6-da26d2e9b760