bazelbuild / intellij

IntelliJ plugin for Bazel projects
https://ij.bazel.build/
Apache License 2.0
760 stars 303 forks source link

fix(output): Ignore sync errors in excluded directories #6460

Closed blorente closed 3 months ago

blorente commented 4 months ago

Checklist

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: N/A

Description of this change

Even if a directory is excluded, Bazel can try to read it and issue errors during sync. We should ignore Bazel errors that come from excluded packages.

Implementation details:

blorente commented 4 months ago

@agluszak fair enough, thanks for taking a look! It is a potentially confusing change to the UX, I appreciate the thoughtfulness.

I'll ping @tpasternak and @mai93 to see if they want the feature, otherwise I'm happy to close the PR.

blorente commented 3 months ago

Synced with @tpasternak online. We'll hold off on landing this because it might hide legitimate errors in third party dependencies.

Our use-case for this is pretty niche (we use it for projects with both Bazel and CMake builds in the same repo), but the right solution is probably to expose another extension point for issue parsers. I'm not going to do that in this PR, so closing this one.