search

bazelbuild / intellij

IntelliJ plugin for Bazel projects
https://ij.bazel.build/
Apache License 2.0
753 stars 297 forks source link

fix: Rely on the bazel zipper instead of zip #6462

Closed blorente closed 1 month ago

blorente commented 1 month ago

Checklist

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

N/A

Description of this change

Not all environments have zip in their path. For instance, some Remote Execution environments like to have very lean workers. Furthermore, we shouldn't rely on all environments having the same version. We replace zip with the bazel jar handler.

We have been using this change internally to build the plugin against our build environment for a few months now.

blorente commented 1 month ago

Yeah, it wasn't my happiest PR to write 😅 . There are java tools like jarjar which can do this, but I erred on the side of not introducing another dependency.

tpasternak commented 1 month ago

ok, now we have #6468

blorente commented 1 month ago

I’ll get on this right now.

On Thu, 6 Jun 2024 at 14:31, Tomasz Pasternak @.***> wrote:

ok, now we have #6468 https://github.com/bazelbuild/intellij/issues/6468

— Reply to this email directly, view it on GitHub https://github.com/bazelbuild/intellij/pull/6462#issuecomment-2152508172, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABMW6PWA57DUU4IKNT3FYI3ZGBQC7AVCNFSM6AAAAABIYTABVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJSGUYDQMJXGI . You are receiving this because you modified the open/close state.Message ID: @.***>