trusted project: respect intellij settings controlling project trustness

[ujohnny]

Checklist

• [ ] I have filed an issue about this change and discussed potential changes with the maintainers.
• [ ] I have received the approval from the maintainers to make this change.
• [ ] This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See the Contributions section in the README for more details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

Do not show dialogs to trust if trust checks are disabled in the intellij platform. Project creation code is handled in a custom way in bazel plugin because any project is trusted by default in intellij. However, bazel plugin always creates a fake project in .cl/ij/aswb folder, so the plugin should handle trust checks by itself.

[mai93]

is this related to https://github.com/bazelbuild/intellij/issues/6490?

[tpasternak]

is this related to #6490?

yes it is

[brian-mcnamara]

Thanks! It may be worth checking @tpasternak if TrustedProjects should come out of Internal status, most of this function could be replaced by other methods in that class

[tpasternak]

Thanks! It may be worth checking @tpasternak if TrustedProjects should come out of Internal status, most of this function could be replaced by other methods in that class

Sorry I don't understand

[brian-mcnamara]

Thanks! It may be worth checking @tpasternak if TrustedProjects should come out of Internal status, most of this function could be replaced by other methods in that class

Sorry I don't understand

Right now https://github.com/JetBrains/intellij-community/blob/master/platform/platform-impl/src/com/intellij/ide/trustedProjects/TrustedProjects.kt#L14 is marked internal, however the logic in this repo could also use getProjectTrustedState as well. I'm just unsure if this project prefers not to use internal apis

[mai93]

do we need to add a similar check to BazelGuard https://github.com/bazelbuild/intellij/blob/master/base/src/com/google/idea/blaze/base/execution/BazelGuard.java#L31?

[brian-mcnamara]

do we need to add a similar check to BazelGuard https://github.com/bazelbuild/intellij/blob/master/base/src/com/google/idea/blaze/base/execution/BazelGuard.java#L31?

We do not have any extensions for that EP so we do not need a check there to fix this issue.

[ujohnny]

do we need to add a similar check to BazelGuard

no because it does not ask for trust.

is marked internal, however the logic in this repo could also use getProjectTrustedState as well. I'm just unsure if this project prefers not to use internal apis

We can't use getProjectTrustedState because we don't have a project yet. It's all because plugin creates a "fake" project in ijwb/clwb and all created projects are trusted by default. So because of this custom behavior in bazel plugin we have to ask explicitly in TrustAwareProjectCreator.

[ujohnny]

I checked this with gateway and I do not observe trust dialogs, so I'm moving forward to merge

[tpasternak]

@mai93 @ujohnny can we cut a hotfix release with this change?

[mai93]

released in version 2024.06.04.0.3