Release: java_tools v13.8.0

keertk commented 2 weeks ago

Link to relevant issue and/or commit: https://github.com/bazelbuild/rules_java/pull/206#issuecomment-2311990554

Other details: java_tools v13.8.0 rules_java 7.11.0

cc @bazelbuild/triage

iancha1992 commented 1 week ago

Step 2: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/258

Step 3: COMMIT_HASH: d677142bec2922674f381a1e54a6a695a56ef395

Step 4:

{
  "version": "v13.8",
  "release": "false",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.8/java_tools_linux-v13.8-rc1.zip",
      "sha": "e480906978b34d1f15fa958699112872c7b5883a3d48b630b6bed574d86523ca"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.8/java_tools_windows-v13.8-rc1.zip",
      "sha": "bae74a8f1c7d3d5f73f944a31446b2d87d4e94966ef9cc0bc6b07de6fed6e382"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.8/java_tools_darwin_x86_64-v13.8-rc1.zip",
      "sha": "78a750e24d0bf0f125f3bb4218f58c4e60343f3d28c834e88bd09c7924c83d8d"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.8/java_tools_darwin_arm64-v13.8-rc1.zip",
      "sha": "7a4bf783c67db892e3e670d61c194a0595df8f151c0684146ec7bcf2057a6500"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/release_candidates/java/v13.8/java_tools-v13.8-rc1.zip",
      "sha": "224287ef2b581795392cbd8b1b9f4306d11abb95bba41ea72810cc9c7872a5f8"
    }
  }
}

Step 5: https://github.com/bazelbuild/rules_java/commit/b52393a1f6860901e95d5fa88de3cfc81129b58e b52393a1f6860901e95d5fa88de3cfc81129b58e

Step 6/7: PR: https://github.com/bazelbuild/bazel/pull/23515 Presubmit: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/23093

Step 8: Downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4115

Step 9:

{
  "version": "v13.8",
  "release": "true",
  "artifacts": {
    "java_tools_linux": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.8/java_tools_linux-v13.8.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.8/java_tools_linux-v13.8.zip",
      "sha": "e480906978b34d1f15fa958699112872c7b5883a3d48b630b6bed574d86523ca"
    },
    "java_tools_windows": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.8/java_tools_windows-v13.8.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.8/java_tools_windows-v13.8.zip",
      "sha": "bae74a8f1c7d3d5f73f944a31446b2d87d4e94966ef9cc0bc6b07de6fed6e382"
    },
    "java_tools_darwin_x86_64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.8/java_tools_darwin_x86_64-v13.8.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.8/java_tools_darwin_x86_64-v13.8.zip",
      "sha": "78a750e24d0bf0f125f3bb4218f58c4e60343f3d28c834e88bd09c7924c83d8d"
    },
    "java_tools_darwin_arm64": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.8/java_tools_darwin_arm64-v13.8.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.8/java_tools_darwin_arm64-v13.8.zip",
      "sha": "7a4bf783c67db892e3e670d61c194a0595df8f151c0684146ec7bcf2057a6500"
    },
    "java_tools": {
      "mirror_url": "https://mirror.bazel.build/bazel_java_tools/releases/java/v13.8/java_tools-v13.8.zip",
      "github_url": "https://github.com/bazelbuild/java_tools/releases/download/java_v13.8/java_tools-v13.8.zip",
      "sha": "224287ef2b581795392cbd8b1b9f4306d11abb95bba41ea72810cc9c7872a5f8"
    }
  }
}

Step 10: https://github.com/bazelbuild/java_tools/releases/tag/java_v13.8

Step 11: rules_java PR: https://github.com/bazelbuild/rules_java/pull/221

Step 12: rules_java released: https://github.com/bazelbuild/rules_java/releases/tag/7.11.1 BCR PR: https://github.com/bazelbuild/bazel-central-registry/pull/2741

Note: https://github.com/bazelbuild/bazel/pull/23571, instead of https://github.com/bazelbuild/bazel/pull/23515 was merged as per https://github.com/bazelbuild/bazel/pull/23515#issuecomment-2339824217. 7.11.1 rules_java instead of 7.11.0 was included.

iancha1992 commented 1 week ago

@hvadehra looks like the downstream (https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/4103) is facing some failures that do not appear in the master branch. Could you please take a look at:

If it's not related to java_tools / rules_cc, I'd be glad to proceed like last time. Please let me know. Thanks!

hvadehra commented 1 week ago

If it's not related to java_tools / rules_cc, I'd be glad to proceed like last time.

Yes, these don't seem related to the java_tools change, but likely due to https://github.com/bazelbuild/rules_java/commit/30ecf3ff6ee8f30b4df505d9d3bde5bb1c25690b (cc @comius)

I suspect the failures are only because as in other cases in the bazel tests, we aren't able to use the unreleased rules_java version correctly everywhere. So I'm optimistic things will be fine after we make the release. It would be great if you could run the downstream again once we finalize the PR with the released version (including in MODULE.tools)

iancha1992 commented 5 days ago

Done - https://github.com/bazelbuild/java_tools/releases/tag/java_v13.8 https://github.com/bazelbuild/rules_java/releases/tag/7.11.1

bazelbuild / java_tools

Release: java_tools v13.8.0 #91