Closed petroseskinder closed 7 years ago
Can one of the admins verify this patch?
@kchodorow I have a few simple questions:
I understand we should include tests with each patch. For a pull request as simple as this, should I include unit tests?
In addition, I kept this CL as simple as possible in terms of change. I decided to exclude the portion about the requesting coordinate, until I got a better sense of how you approached reviewing CL's. Let me know if you want me to include those.
Your comments were noted, and fixes are up. It makes sense why the time would be useful (you would want to know when you started to download a pom).
No worries! In the future, you don't have to worry about squashing commits. GitHub gives me the option to squash or rebase before merging the PR.
Simple change to print currently downloaded maven jar to console.
reviewer: @kchodorow cc: @hhclam