search

bazelbuild / migration-tooling

Migration tools for Bazel
Apache License 2.0
45 stars 30 forks source link

Print currently downloaded maven jar to console #21

Closed petroseskinder closed 7 years ago

petroseskinder commented 7 years ago

Simple change to print currently downloaded maven jar to console.

____Running command line: bazel-bin/generate_workspace/generate_workspace '--artifact=org.powermock:powermock-module-junit4:1.5.1'

    Downloading maven artifact org.powermock:powermock-module-junit4:1.5.1
    Downloading maven artifact junit:junit:4.11
    Downloading maven artifact org.hamcrest:hamcrest-core:1.3
    Downloading maven artifact org.powermock:powermock-module-junit4-common:1.5.1
    Downloading maven artifact org.powermock:powermock-core:1.5.1
    Downloading maven artifact org.powermock:powermock-reflect:1.5.1
    Downloading maven artifact org.objenesis:objenesis:1.2
    Downloading maven artifact org.javassist:javassist:3.18.0-GA
Wrote /private/var/tmp/_bazel_petroseskinder/f4ae163fe842998e2d78cf9f858a5836/execroot/migration-tooling/bazel-out/local-fastbuild/bin/generate_workspace/generate_workspace.runfiles/__main__/generate_workspace.bzl

reviewer: @kchodorow cc: @hhclam

bazel-io commented 7 years ago

Can one of the admins verify this patch?

petroseskinder commented 7 years ago

@kchodorow I have a few simple questions:

I understand we should include tests with each patch. For a pull request as simple as this, should I include unit tests?

In addition, I kept this CL as simple as possible in terms of change. I decided to exclude the portion about the requesting coordinate, until I got a better sense of how you approached reviewing CL's. Let me know if you want me to include those.

petroseskinder commented 7 years ago

Your comments were noted, and fixes are up. It makes sense why the time would be useful (you would want to know when you started to download a pom).

kchodorow commented 7 years ago

No worries! In the future, you don't have to worry about squashing commits. GitHub gives me the option to squash or rebase before merging the PR.